Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the librarian configuration by modifying a tracking issue link and replacing 'google-cloud-dialogflow' with 'google-crc32c' in the blocked generation list. Feedback points out that the descriptive comment was not updated to reflect the new library ID, creating an inconsistency, and questions whether 'google-crc32c' should have been added as a new entry rather than replacing the existing one.
| # TODO(https://github.com/googleapis/google-cloud-python/issues/16520): | ||
| # Allow generation for google-cloud-dialogflow once this bug is fixed. | ||
| - id: "google-cloud-dialogflow" | ||
| - id: "google-crc32c" |
There was a problem hiding this comment.
The library google-cloud-dialogflow is being replaced by google-crc32c. If the intention was to block both, google-crc32c should be added as a new entry. Additionally, the comment on line 36 still refers to google-cloud-dialogflow, making it inconsistent with the updated ID and issue link.
ohmayr
added
the
do not merge
ohmayr
force-pushed
the
block-release-for-python-packages
branch
2 times, most recently
from
ff3c5ab to
4925532
Compare
ohmayr
force-pushed
the
block-release-for-python-packages
branch
2 times, most recently
from
f98b221 to
e3b4144
Compare
ohmayr
force-pushed
the
block-release-for-python-packages
branch
from
e3b4144 to
eb7a6a1
Compare
2 participants
Disable generation for
google-crc32c.