feat(firestore): add DML support to pipelines#16473
Open
daniel-sanche wants to merge 11 commits intomainfrom
Open
feat(firestore): add DML support to pipelines#16473daniel-sanche wants to merge 11 commits intomainfrom
daniel-sanche wants to merge 11 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces delete and update stages to the Firestore pipeline, enabling document deletion and in-place updates. The changes include new stage implementations, pipeline methods, and comprehensive system tests. Feedback highlights a logic error in the test assertions where empty documents were incorrectly identified as deleted, and suggests clarifying the update method's documentation to distinguish between partial updates and full document saves. Additionally, a more explicit syntax for field transformations in YAML tests was recommended for better consistency.
packages/google-cloud-firestore/tests/system/test_pipeline_acceptance.py
Outdated
Show resolved
Hide resolved
packages/google-cloud-firestore/tests/system/test_pipeline_acceptance.py
Outdated
Show resolved
Hide resolved
packages/google-cloud-firestore/google/cloud/firestore_v1/base_pipeline.py
Outdated
Show resolved
Hide resolved
packages/google-cloud-firestore/tests/system/pipeline_e2e/dml.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
daniel-sanche
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Data Manipulation Language, making pipelines read/write instead of read-only
New Stages:
DeleteUpdateNew e2e test assertion:
assert_end_state, to assert that the database is in a certain state after running a pipeline