Skip to content

fix: harden Regional Access Boundary universe domain checks - #9859

Draft
bshaffer wants to merge 5 commits into
mainfrom
auth/rab-universe-domain
Draft

bshaffer wants to merge 5 commits into
mainfrom
auth/rab-universe-domain

Conversation

@bshaffer

Copy link
Copy Markdown
Contributor

Harden Regional Access Boundary (RAB) gating across Auth and Gax so lookups are skipped for non-default universe domains even when RAB is explicitly opted in and credential fields are incomplete:

  • Read top-level universe_domain in ImpersonatedServiceAccountCredentials (and propagate it to array source_credentials when unset)
  • Gate RAB lookups on default-universe endpoint hosts across impersonated, external account, and service account credentials
  • Check universe_domain before building the lookup URL in ExternalAccountCredentials and before fetching the service account email in GCECredentials
  • Disable RAB in GapicClientTrait and CredentialsWrapper::build() when universeDomain is not googleapis.com (and strip ports when checking regional endpoints)
  • Default $enableRegionalAccessBoundary to false in CredentialsWrapper::buildApplicationDefaultCredentials()

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant