fix: cast Core upload header values to strings

Core/src/Upload/MultipartUploader.php

@@ -95,7 +95,7 @@ private function prepareRequest()
 
         $size = $multipartStream->getSize();
         if ($size !== null) {
-            $headers['Content-Length'] = $size;
+            $headers['Content-Length'] = (string) $size;
         }
 
         $customHeaders = $this->requestOptions['restOptions']['headers'] ?? [];

Core/src/Upload/ResumableUploader.php

@@ -165,7 +165,7 @@ public function upload()
             $rangeEnd = $rangeStart + ($currStreamLimitSize - 1);
 
             $headers = $this->headers + [
-                'Content-Length' => $currStreamLimitSize,
+                'Content-Length' => (string) $currStreamLimitSize,
                 'Content-Type' => $this->contentType,
                 'Content-Range' => "bytes $rangeStart-$rangeEnd/$size",
             ];
@@ -245,7 +245,7 @@ protected function createResumeUri()
     {
         $headers = $this->headers + [
             'X-Upload-Content-Type' => $this->contentType,
-            'X-Upload-Content-Length' => $this->data->getSize(),
+            'X-Upload-Content-Length' => (string) $this->data->getSize(),
             'Content-Type' => 'application/json'
         ];
 

Core/src/Upload/SignedUrlUploader.php

@@ -71,7 +71,7 @@ protected function createResumeUri()
     {
         $headers = $this->headers + [
             'Content-Type' => $this->contentType,
-            'Content-Length' => 0,
+            'Content-Length' => '0',
             'x-goog-resumable' => 'start'
         ];
 

Core/src/Upload/StreamableUploader.php

@@ -59,7 +59,7 @@ public function upload($writeSize = null)
 
         // do the streaming write
         $headers = [
-            'Content-Length'    => $writeSize,
+            'Content-Length'    => (string) $writeSize,
             'Content-Type'      => $this->contentType,
             'Content-Range'     => "bytes {$this->rangeStart}-$rangeEnd/*"
         ];

Core/tests/Unit/Upload/MultipartUploaderTest.php

@@ -137,6 +137,11 @@ public function testStreamWithoutSizeDoesNotReceiveContentLengthHeader($stream,
             Argument::that(
                 function (RequestInterface $request) use ($shouldContentLengthExist) {
                     $this->assertEquals($request->hasHeader('Content-Length'), $shouldContentLengthExist);
+
+                    foreach ($request->getHeader('Content-Length') as $value) {
+                        $this->assertIsString($value);
+                    }
+
                     return true;
                 }
             ),

Core/tests/Unit/Upload/ResumableUploaderTest.php

@@ -111,7 +111,9 @@ public function testGetResumeUri()
         $response = new Response(200, ['Location' => $resumeUri]);
 
         $this->requestWrapper->send(
-            Argument::type(RequestInterface::class),
+            Argument::that(function (RequestInterface $request) {
+                return $request->getHeader('X-Upload-Content-Length') === ['4'];
+            }),
             Argument::type('array')
         )->willReturn($response);
 
@@ -282,6 +284,7 @@ public function testUploadDoesNotSendGoogHashOnIntermediateChunk()
         $this->requestWrapper->send(
             Argument::that(function (RequestInterface $request) {
                 return $request->getHeaderLine('Content-Range') === 'bytes 0-1/4'
+                    && $request->getHeader('Content-Length') === ['2']
                     && !$request->hasHeader('X-Goog-Hash');
             }),
             Argument::type('array')

Core/tests/Unit/Upload/SignedUrlUploaderTest.php

@@ -62,7 +62,7 @@ public function testGetResumeUri()
                     return false;
                 }
 
-                if ($arg->getHeaderLine('Content-Length') != 0) {
+                if ($arg->getHeader('Content-Length') !== ['0']) {
                     return false;
                 }
 

Core/tests/Unit/Upload/StreamableUploaderTest.php

@@ -160,7 +160,7 @@ public function testLastChunkSendsCorrectHeaders()
 
         $this->requestWrapper->send(
             Argument::that(function ($request) {
-                return $request->getHeaderLine('Content-Length') == '10';
+                return $request->getHeader('Content-Length') === ['10'];
             }),
             Argument::type('array')
         )->willReturn($response)->shouldBeCalled();