feat(chronicle): bundle backstory UDM protos into @google-cloud/chronicle - #9189
Draft
quirogas wants to merge 2 commits into
Draft
feat(chronicle): bundle backstory UDM protos into @google-cloud/chronicle#9189quirogas wants to merge 2 commits into
quirogas wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds several backstory protobuf definitions—including collection, data_access, entity, entity_risk, and id—and registers them in librarian.yaml and various service proto list JSON files. However, the referenced udm.proto file is missing from the pull request, which will lead to build and generation failures.
| - backstory/entity.proto | ||
| - backstory/entity_risk.proto | ||
| - backstory/id.proto | ||
| - backstory/udm.proto |
Contributor
There was a problem hiding this comment.
The file packages/google-cloud-chronicle/protos/backstory/udm.proto is listed here as an additional proto and is referenced in the service proto lists, but it has not been added to this pull request. Please make sure to add the udm.proto file to the repository to prevent build and generation failures.
quirogas
marked this pull request as draft
August 21, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle backstory Chronicle UDM protobuf definitions directly into the
@google-cloud/chronicleclient library package.For b/512097657