feat(generator): add internalTelemetryInfo configuration to nunjucks templates

[shivanee-p]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces telemetry tracing configuration (internalTelemetryInfo) to the generated service client templates for both CommonJS and ESM formats when telemetry tracing is enabled. The review feedback highlights a critical issue where directly mutating the opts object can lead to a TypeError if opts is undefined, or cause unintended side-effects if the options object is reused. It is recommended to safely clone opts using Object.assign({}, opts) before assigning the telemetry properties.

[gemini-code-assist]

Directly mutating the opts object passed to the constructor is unsafe and can lead to unexpected side-effects if the user reuses the options object across multiple clients. Additionally, since opts is optional (opts?: ClientOptions), attempting to set properties on it directly will throw a TypeError at runtime if the client is instantiated without options.

To prevent both issues, create a shallow copy of opts using Object.assign({}, opts) before assigning the telemetry info. This safely handles undefined (resulting in an empty object {}) and protects the user's original configuration from mutation.

    {%- if api.enableTelemetryTracing %}
      opts = Object.assign({}, opts);
      opts.internalTelemetryInfo = {
        gcpClientService: '{{ api.loggingName }}',
        gcpClientVersion: '{{ api.naming.version }}',
        gcpRepo: 'googleapis/google-cloud-node',
        gcpArtifact: '{{ api.publishName }}',
      };
    {%- endif %}

[gemini-code-assist]

Directly mutating the opts object passed to the constructor is unsafe and can lead to unexpected side-effects if the user reuses the options object across multiple clients. Additionally, since opts is optional (opts?: ClientOptions), attempting to set properties on it directly will throw a TypeError at runtime if the client is instantiated without options.

To prevent both issues, create a shallow copy of opts using Object.assign({}, opts) before assigning the telemetry info. This safely handles undefined (resulting in an empty object {}) and protects the user's original configuration from mutation.

    {%- if api.enableTelemetryTracing %}
      opts = Object.assign({}, opts);
      opts.internalTelemetryInfo = {
        gcpClientService: '{{ api.loggingName }}',
        gcpClientVersion: '{{ api.naming.version }}',
        gcpRepo: 'googleapis/google-cloud-node',
        gcpArtifact: '{{ api.publishName }}',
      };
    {%- endif %}