Skip to content

chore(storage): remove form-data dependency use native globals and update package scripts #9120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thiyaguk09 wants to merge 7 commits into
base: main
Choose a base branch
from
+2 −9
Open

chore(storage): remove form-data dependency use native globals and update package scripts #9120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4adf81b
chore: remove unused form-data and node-fetch dependencies
thiyaguk09 Aug 11, 2026
ed7594e
chore: remove samples-test script and simplify test execution command
thiyaguk09 Aug 11, 2026
915f1ee
chore: update test script to preload yargs and add cross-env dependency
thiyaguk09 Aug 11, 2026
c9eabf6
chore: remove node-fetch dependency and associated types
thiyaguk09 Aug 11, 2026
033de68
chore: update retry-request and teeny-request versions and remove @ty…
thiyaguk09 Aug 11, 2026
a810537
Merge branch 'main' into fix/7348-form-data-vulnerability
thiyaguk09 Aug 17, 2026
8e1a019
chore: add @types/request to devDependencies in storage package.json
thiyaguk09 Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion handwritten/storage/conformance-test/conformanceCommon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import {Bucket, File, HmacKey, Notification, Storage} from '../src/';
import * as crypto from 'crypto';
import * as assert from 'assert';
import {DecorateRequestOptions} from '../src/nodejs-common';
import fetch from 'node-fetch';

interface RetryCase {
instructions: String[];
Expand Down
8 changes: 2 additions & 6 deletions handwritten/storage/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"storage"
],
"scripts": {
"all-test": "npm test && npm run system-test && npm run samples-test",
"all-test": "npm test && npm run system-test",
Comment thread
thiyaguk09 marked this conversation as resolved.
"benchwrapper": "node bin/benchwrapper.js",
"check": "gts check",
"clean": "rm -rf build/",
Expand All @@ -68,7 +68,6 @@
"presystem-test:esm": "npm run compile:esm",
"presystem-test": "npm run compile -- --sourceMap",
"pretest": "npm run compile -- --sourceMap",
"samples-test": "npm link && cd samples/ && npm link ../ && npm test && cd ../",
"system-test:esm": "mkdir -p $HOME/.config && mocha build/esm/system-test --timeout 600000 --exit",
"system-test": "mkdir -p $HOME/.config && mocha build/cjs/system-test --timeout 600000 --exit",
"test": "cross-env NODE_OPTIONS=\"--require ./scripts/preload-yargs.cjs --no-deprecation\" c8 mocha build/cjs/test"
Expand Down Expand Up @@ -101,14 +100,12 @@
"@types/mocha": "^9.1.1",
"@types/mockery": "^1.4.29",
"@types/node": "^24.0.0",
"@types/node-fetch": "^2.1.3",
"@types/proxyquire": "^1.3.28",
"@types/request": "^2.48.4",
"@types/request": "^2.48.12",
"@types/sinon": "^17.0.0",
"@types/tmp": "0.2.6",
"@types/yargs": "^17.0.35",
"c8": "^9.0.0",
"form-data": "^4.0.4",
"gapic-tools": "^2.0.1",
"gts": "^5.0.0",
"jsdoc": "^4.0.4",
Expand All @@ -117,7 +114,6 @@
"mocha": "^9.2.2",
"mockery": "^2.1.0",
"nock": "~13.5.0",
"node-fetch": "^2.6.7",
"pack-n-play": "^5.0.1",
"proxyquire": "^2.1.3",
"sinon": "^18.0.0",
Expand Down
2 changes: 0 additions & 2 deletions handwritten/storage/system-test/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ import assert from 'assert';
import {after, afterEach, before, beforeEach, describe, it} from 'mocha';
import * as crypto from 'crypto';
import * as fs from 'fs';
import fetch from 'node-fetch';
import FormData from 'form-data';
import pLimit from 'p-limit';
import {promisify} from 'util';
import * as path from 'path';
Expand Down
Loading