fix(cloud-profiler): re-enable tests#8828
Open
aabmass wants to merge 2 commits into
Open
Conversation
product-auto-label
Bot
added
the
api: cloudprofiler
aabmass
force-pushed
the
push-stsosypynvny
branch
2 times, most recently
from
f5ade47 to
d5ced77
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the package.json file in handwritten/cloud-profiler to enable unit and system tests using mocha and c8 instead of skipping them. Feedback is provided to wrap the glob patterns in single quotes to ensure cross-platform compatibility, particularly on Windows where shell glob expansion behaves differently.
aabmass
force-pushed
the
push-stsosypynvny
branch
4 times, most recently
from
9341bad to
d2a0217
Compare
aabmass
force-pushed
the
push-stsosypynvny
branch
2 times, most recently
from
16321fe to
c530845
Compare
aabmass
force-pushed
the
push-stsosypynvny
branch
2 times, most recently
from
98934c5 to
955d2d6
Compare
Restores the `test` and `system-test` scripts that were previously disabled in googleapis/cloud-profiler-nodejs#1002.
aabmass
force-pushed
the
push-stsosypynvny
branch
from
955d2d6 to
ec2b64a
Compare
aabmass
commented
Jul 7, 2026
|
|
||
| # Our CI uses Git Bash on Windows to execute this script, which returns "msys" for OSTYPE. | ||
| if [[ "$OSTYPE" == "msys" ]]; then | ||
| # Our CI uses Git Bash on Windows to execute this script, which returns "msys" or "cygwin" for OSTYPE. |
Contributor
Author
There was a problem hiding this comment.
Turned out $OSTYPE is set to cygwin on the Windows GHA runners, which bypassed the original msys check. Adding cygwin and the $OS fallback makes sure we skip Windows-exempt tests correctly on both GHA and local setups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the
test(unit test) script that was previously disabled in googleapis/cloud-profiler-nodejs#1002.Note: GCE system tests (
system-test) remain disabled for now as they require a GCE project environment to run.Note: Native module compilation (via
node-gyp) fails on GitHub Actions Windows runners due to runner-specific environment issues. Consequently,handwritten/cloud-profiler/has been added to the Windows test exemption list inci/run_conditional_tests.sh.