Skip to content

chore: example changes from Release Please files by Librarian#8777

Draft
suztomo wants to merge 1 commit into
googleapis:mainfrom
suztomo:before-agentregistry
Draft

chore: example changes from Release Please files by Librarian#8777
suztomo wants to merge 1 commit into
googleapis:mainfrom
suztomo:before-agentregistry

Conversation

@suztomo

@suztomo suztomo commented Jun 29, 2026

Copy link
Copy Markdown
Member

These changes come from "librarian add" command with the enhancement
of managing Release Please files by Librarian.

suztomo@suztomo:~/librarian-2026/librarian$ go build  -o /tmp/librarian ./cmd/librarian
suztomo@suztomo:~/librarian-2026/librarian$ cd ../google-cloud-node
suztomo@suztomo:~/librarian-2026/google-cloud-node$ git checkout -b before-agentregistry 51f4a308226ea49ed234b01211413a1d2732de24
suztomo@suztomo:~/librarian-2026/google-cloud-node$ /tmp/librarian add google/cloud/agentregistry/v1

51f4a30 was the parent commit of
the commit that added the agentregistry package in google-cloud-node.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes and alphabetizes package definitions across release configuration files, adds the new library google-cloud-agentregistry, and removes unused mixins configurations from several libraries in librarian.yaml. Feedback is provided regarding the missing version field for the newly added google-cloud-agentregistry library in librarian.yaml to ensure consistency with other definitions.

Comment thread librarian.yaml
Comment on lines +195 to +196
- name: google-cloud-agentregistry
apis:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new library google-cloud-agentregistry is missing the version field. To maintain consistency with other library definitions in this file, please add the version field matching the 0.0.0 version specified in .release-please-manifest.json.

  - name: google-cloud-agentregistry
    version: 0.0.0
    apis:

@suztomo suztomo force-pushed the before-agentregistry branch from e466b2f to bdd87d7 Compare June 29, 2026 20:22
These changes come from "librarian add" command with the enhancement
of managing Release Please files by Librarian.

```
suztomo@suztomo:~/librarian-2026/librarian$ go build  -o /tmp/librarian ./cmd/librarian
suztomo@suztomo:~/librarian-2026/librarian$ cd ../google-cloud-node
suztomo@suztomo:~/librarian-2026/google-cloud-node$ git checkout -b before-agentregistry 51f4a30
suztomo@suztomo:~/librarian-2026/google-cloud-node$ /tmp/librarian add google/cloud/agentregistry/v1
```

51f4a30 was the parent commit of
the commit that added the agentregistry package in google-cloud-node.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant