Skip to content

chore: copy google-cloud-sql from googleapis-gen#8770

Open
JoeWang1127 wants to merge 8 commits into
googleapis:mainfrom
JoeWang1127:chore/owlbot-copy-google-cloud-sql
Open

chore: copy google-cloud-sql from googleapis-gen#8770
JoeWang1127 wants to merge 8 commits into
googleapis:mainfrom
JoeWang1127:chore/owlbot-copy-google-cloud-sql

Conversation

@JoeWang1127

@JoeWang1127 JoeWang1127 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Copy google-cloud-sql from googleapis-gen.

Step to copy the code:

docker run --rm --user $(id -u):$(id -g) -v .:/repo -w /repo -v ../googleapis-gen:/googleapis-gen --env HOME=/tmp gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-code  --source-repo=/googleapis-gen --config-file=packages/google-cloud-sql/.OwlBot.yaml

docker run --rm --user $(id -u):$(id -g) -v $(pwd):/repo -w /repo   --env HOME=/tmp   gcr.io/cloud-devrel-public-resources/owlbot-nodejs-mono-repo:latest packages/google-cloud-sql

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several updates to the Google Cloud SQL Node.js client, including the addition of the ResolveConnectSettings RPC, the new SqlDataService for bidirectional SQL data streaming, and various new configuration fields (such as performance capture thresholds and accelerated replica mode). However, the reviewer noted a critical issue: several newly exported service clients in both v1 and v1beta4 index files are missing their corresponding implementation files, which will lead to compilation and build failures.

Comment thread packages/google-cloud-sql/src/v1/index.ts Outdated
Comment thread packages/google-cloud-sql/src/v1beta4/index.ts Outdated
@JoeWang1127 JoeWang1127 marked this pull request as ready for review June 30, 2026 00:15
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner June 30, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant