fix(pubsub): remove messages from leasing on nackWithResponse#7817
Draft
fix(pubsub): remove messages from leasing on nackWithResponse#7817
Conversation
pearigee
approved these changes
Mar 18, 2026
|
|
||
| it('should modAck the message with a 0 deadline (nackWithResponse)', async () => { | ||
| const stub = sandbox.stub(subscriber, 'modAckWithResponse'); | ||
|
|
Contributor
There was a problem hiding this comment.
This is a super nit of me, but Google's unit test best practices (see go/unit-testing-practices?polyglot=typescript#structure) recommend that unit tests be structured into clear arrange, act, and assert steps with whitespace.
I think that would make your test look like this:
const stub = sandbox.stub(subscriber, 'modAckWithResponse');
await subscriber.nackWithResponse(message);
const [msg, deadline] = stub.lastCall.args;
assert.strictEqual(msg, message);
assert.strictEqual(deadline, 0);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening a fix for this in the new repo.
Fixes #7625 🦕