Repository navigation
docs(bigquery): fix uncompilable Javadoc snippets and copy-paste labels - #15122
Merged
lqiu96 merged 2 commits intoNov 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request performs a comprehensive cleanup of Javadoc comments and code examples across various classes in the google-cloud-bigquery library. Key changes include correcting inaccurate terminology (such as replacing 'table' with 'model', 'routine', or 'job' where appropriate), fixing variable names and method calls in code snippets, replacing raw HTML/markdown formatting with standard Javadoc tags like {@code}, and correcting typographical errors like curly quotes. There are no review comments to address, and the changes look excellent as they significantly improve documentation accuracy and readability.
jinseopkim0
approved these changes
Nov 20, 2026
…and FieldValue/JobOption Javadocs
lqiu96
enabled auto-merge (squash)
November 20, 2026 23:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes uncompilable Javadoc code snippets, malformed Javadoc tags, copy-pasted resource labels, and leaked internal comments across
java-bigquery(Javadoc-only, no behavioral changes).Summary of changes
Dataset.java: replace curly quotes (“...”) ingetandcreateexamples with ASCII quotes.InsertAllRequest.java: replace package-privatenew RowToInsert(...)withRowToInsert.of(...)and non-existentInsertAllRequest.builder(...)withInsertAllRequest.newBuilder(...).BigQuery.java: fix mismatched/duplicate local variable names indelete(ModelId),delete(RoutineId), andgetModel(ModelId), and replace the copy-pastedTablesnippet onupdate(DatasetInfo)with aDatasetupdate snippet.Connection.javaandConnectionImpl.java: fix malformed<pre>{ @codeblocks, add a missing semicolon onexecuteSelect, updatesetRequestTimeout(10L)to10000L(ms), fix..setUseReadAPI(true)and mismatchedexecuteSelectFut/executeSelectFuture, replace nonexistentexecuteSelectRes.getBigQueryResult()withexecuteSelectRes.getResultSet(), and use column names ("corpus","StringField") instead ofrs.getString(1).BigQuery(ModelListOption,RoutineOption,JobListOption.fields,JobOption),Table.update,Model(exists,update, class Javadoc),QueryJobConfiguration.of(Copy Job->Query Job configuration),QueryParameterValue.getRangeValues,FieldValue.getTimestampInstant({@code String}->{@link Instant}), andFieldValueList.get(String)(by index->by name).//inField.setPrecision, remove leaked(-- ... --)internal proto comments inField.setCollationandDatasetInfo.setDefaultCollation, and replace raw Markdown triple backticks and duplicated text inRemoteFunctionOptions.Verification
mvn -f java-bigquery/google-cloud-bigquery/pom.xml com.spotify.fmt:fmt-maven-plugin:check -Dlint checkstyle:check@checkstyle test-compile(0 Checkstyle violations, 0 formatting issues)javadoc -Xdoclint:syntax,html,referenceon all 14 modified files (0 warnings/errors)com.example.caller) underjavac --release 8(0 errors)