Skip to content

chore(compute): add OpenTelemetry observability validation tests - #15119

Open
jinseopkim0 wants to merge 2 commits into
mainfrom
chore-compute-observability-validation
Open

jinseopkim0 wants to merge 2 commits into
mainfrom
chore-compute-observability-validation

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

Adds fast, self-contained observability validation tests (ComputeObservabilityValidationTest) for the Compute GAPIC client using MockHttpService and in-memory OpenTelemetry exporters.

Validates parent trace context propagation, T3/T4 span hierarchy and HTTP/JSON attributes, golden signal duration metrics with T3 span exemplars, and L4/L3 actionable error log span correlation via GOOGLE_SDK_JAVA_LOGGING=true for both success and error responses.

b/564460092

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces ComputeObservabilityValidationTest to validate OpenTelemetry traces, golden signal metrics, exemplars, and error logging correlation for the Compute GAPIC client. The feedback suggests making the test self-contained by explicitly setting the google.sdk.java.logging system property during setup, and clearing it during teardown along with stopping the test appender to prevent side effects on other tests.

@jinseopkim0

Copy link
Copy Markdown
Contributor Author

@gemini-code-assist review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new test class, ComputeObservabilityValidationTest, to validate OpenTelemetry integration (including traces, metrics, exemplars, and logging correlation) on the Compute GAPIC client using an in-memory mock transport. There are no review comments, so I have no feedback to provide.

@jinseopkim0
jinseopkim0 marked this pull request as ready for review November 20, 2026 23:04
@jinseopkim0
jinseopkim0 requested a review from a team as a code owner November 20, 2026 23:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant