Skip to content

chore: add showcase integration tests for OpenTelemetry span scope in logging and metrics - #15041

Merged
jinseopkim0 merged 2 commits into
mainfrom
chore-showcase-span-scope-it
Nov 20, 2026
Merged

jinseopkim0 merged 2 commits into
mainfrom
chore-showcase-span-scope-it

Conversation

@jinseopkim0

@jinseopkim0 jinseopkim0 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Adds Showcase integration tests verifying that diagnostic error logs (L4/L3), golden signal metric exemplars (M1), and downstream gRPC client interceptors observe the active OpenTelemetry span across HTTP/JSON and gRPC calls, including nested CompositeTracerFactory configurations.

b/499388983
b/570676007

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces integration tests to verify that OpenTelemetry span contexts are correctly captured and correlated during error logging for both HTTP/JSON and gRPC transports. Specifically, it adds testHttpJson_spanContextCapturedInScopeDuringErrorLog and testGrpc_spanContextCapturedInScopeDuringErrorLogAndDownstreamInterceptor to ITActionableErrorsLogging.java, along with helper methods to build a nested composite tracer factory and assert span correlation. Additionally, TestAppender.java is updated to capture and store the active OpenTelemetry SpanContext when log events are appended. I have no feedback to provide as the changes are well-implemented and there are no existing review comments to address.

@jinseopkim0
jinseopkim0 force-pushed the base-showcase-span-scope branch from e3c88c8 to d6883d7 Compare November 17, 2026 02:26
@jinseopkim0
jinseopkim0 force-pushed the chore-showcase-span-scope-it branch from 84a3d91 to e991eb0 Compare November 17, 2026 02:26
@jinseopkim0
jinseopkim0 requested a review from blakeli0 November 17, 2026 02:32
@jinseopkim0
jinseopkim0 marked this pull request as ready for review November 17, 2026 02:32
@jinseopkim0
jinseopkim0 requested a review from a team as a code owner November 17, 2026 02:32
@jinseopkim0
jinseopkim0 force-pushed the chore-showcase-span-scope-it branch from e991eb0 to fb4e023 Compare November 20, 2026 21:47
@jinseopkim0
jinseopkim0 requested review from a team as code owners November 20, 2026 21:47
@jinseopkim0
jinseopkim0 changed the base branch from base-showcase-span-scope to main November 20, 2026 21:47
@jinseopkim0
jinseopkim0 enabled auto-merge (squash) November 20, 2026 22:33
@jinseopkim0
jinseopkim0 requested a review from blakeli0 November 20, 2026 22:33
@jinseopkim0
jinseopkim0 merged commit 63aa234 into main Nov 20, 2026
192 checks passed
@jinseopkim0
jinseopkim0 deleted the chore-showcase-span-scope-it branch November 20, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants