Skip to content

fix(datastore): update emulator zip checksum for 2.3.1 The checksum handed to DownloadableEmulatorRunner is still the one for the 2.0.2 archive. 9eb86f06 bumped MIN_VERSION from 2.0.2 to 2.3.1 but left MD5_CHECKSUM alone, so BaseEmulatorHelper.downloadZipFile() never finds a match and start() re-fetches the ~36 MB zip every time. Fixes #12058 #14592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rootkiller6788 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(datastore): update emulator zip checksum for 2.3.1 The checksum handed to DownloadableEmulatorRunner is still the one for the 2.0.2 archive. 9eb86f06 bumped MIN_VERSION from 2.0.2 to 2.3.1 but left MD5_CHECKSUM alone, so BaseEmulatorHelper.downloadZipFile() never finds a match and start() re-fetches the ~36 MB zip every time. Fixes #12058 #14592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8ed233
fix(datastore): update emulator zip checksum for 2.3.1
rootkiller6788 Sep 21, 2026
118752f
fix(datastore): use the resolved consistency for the gcloud runner too
rootkiller6788 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...loud-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public class LocalDatastoreHelper extends BaseEmulatorHelper<DatastoreOptions> {
// Downloadable emulator settings
private static final String BIN_NAME = "cloud-datastore-emulator/cloud_datastore_emulator";
private static final String FILENAME = "cloud-datastore-emulator-" + MIN_VERSION + ".zip";
private static final String MD5_CHECKSUM = "e0d1170519cf52e2e5f9f93892cdf70c";
private static final String MD5_CHECKSUM = "7c1f5a3276241a8f78cb1a837daaaa47";
private static final String BIN_CMD_PORT_FLAG = "--port=";
private static final URL EMULATOR_URL;
private static final String EMULATOR_URL_ENV_VAR = "DATASTORE_EMULATOR_URL";
Expand Down Expand Up @@ -176,7 +176,7 @@ private LocalDatastoreHelper(Builder builder) {
} else {
// At most one of --consistency | --use-firestore-in-datastore-mode can be specified.
// --consistency will be ignored with --use-firestore-in-datastore-mode.
gcloudCommand.add(CONSISTENCY_FLAG + builder.consistency);
gcloudCommand.add(CONSISTENCY_FLAG + getConsistency());

@gemini-code-assist gemini-code-assist Bot Oct 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Calling the overridable instance method getConsistency() inside the constructor is risky. If LocalDatastoreHelper is subclassed, the subclass's version of getConsistency() could be invoked before the subclass is fully initialized, which violates the general Java practice of not calling overridable methods in constructors (Effective Java, Item 19). To avoid this, resolve the consistency value directly from the builder using the DEFAULT_CONSISTENCY constant.

Suggested change
gcloudCommand.add(CONSISTENCY_FLAG + getConsistency());
gcloudCommand.add(CONSISTENCY_FLAG + (builder.consistency == 0.0 ? DEFAULT_CONSISTENCY : builder.consistency));

}
if (!builder.storeOnDisk) {
gcloudCommand.add("--no-store-on-disk");
Expand Down
Loading