feat(gax): add StringHttpResponseParser - #14135
Draft
whowes wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces StringHttpResponseParser, a new implementation of HttpResponseParser that reads HTTP response bodies as UTF-8 strings. It also includes a comprehensive suite of unit tests in StringHttpResponseParserTest covering successful parsing from input streams and readers, empty inputs, error handling, and serialization. I have no further feedback to provide as the implementation is clean and well-tested.
whowes
changed the title
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently gax-httpjson includes only one HTTP response parser (ProtoMessageResponseParser) which assumes response bodies can be parsed into protos.
Resumable upload HTTP operations will return non-proto responses (including empty response bodies where all metadata is exchanged via headers/return code) so we'll need a more general response parser to be able to use the existing HTTP stack to talk to the upload service.