Skip to content

test(bigquerystorage): increase await timeout for createReadSession to 1 minute - #14125

Open
lqiu96 wants to merge 2 commits into
googleapis:mainfrom
lqiu96:auto_repair_sponge_failure
Open

test(bigquerystorage): increase await timeout for createReadSession to 1 minute#14125
lqiu96 wants to merge 2 commits into
googleapis:mainfrom
lqiu96:auto_repair_sponge_failure

Conversation

@lqiu96

@lqiu96 lqiu96 commented Aug 19, 2026

Copy link
Copy Markdown
Member

Description

Increases the await() timeout to 1 minute in ITBigQueryStorageTest (v1beta1, v1beta2) and adds the 1-minute retry logic to the production v1 test helper (Helper.processRowsAtSnapshot) when creating read sessions.

Context

In CI environments, table metadata propagation from bigquery.googleapis.com to bigquerystorage.googleapis.com can take longer than 10 seconds, causing ConditionTimeoutException or NotFoundException test flakes (e.g., in sponge/b1dc622b-9c70-41cb-953e-74c2dfbb3f31).

Setting a 1-minute retry ceiling:

  • Provides sufficient buffer for metadata propagation across busy CI runners.
  • Ensures consistency across v1, v1beta1, and v1beta2 test suites.
  • Matches the 1-minute timeout used elsewhere in the test suite (e.g. job.waitFor(..., RetryOption.totalTimeoutDuration(Duration.ofMinutes(1)))).
  • Adds zero extra latency to successful runs, as await() returns immediately upon session creation.

@lqiu96
lqiu96 requested review from a team as code owners August 19, 2026 18:31

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the await timeout from 10 seconds to 1 minute in the integration tests for both v1beta1 and v1beta2 BigQuery Storage clients, specifically within the ProcessRowsAtSnapshot helper method. This change allows more time for newly-created tables to propagate. There are no review comments, and I have no feedback to provide.

@lqiu96
lqiu96 force-pushed the auto_repair_sponge_failure branch from 12bee0b to b2327e7 Compare August 19, 2026 18:33
@lqiu96
lqiu96 enabled auto-merge (squash) August 19, 2026 18:58
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2026
@lqiu96 lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 19, 2026
@lqiu96 lqiu96 added the release-please:force-run To run release-please label Aug 19, 2026
@release-please release-please Bot removed the release-please:force-run To run release-please label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants