refactor(gax): add constructor to HttpJsonStatusRuntimeException - #14121
Closed
whowes wants to merge 1 commit into
Closed
refactor(gax): add constructor to HttpJsonStatusRuntimeException#14121whowes wants to merge 1 commit into
whowes wants to merge 1 commit into
Conversation
whowes
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new constructor overload in HttpJsonStatusRuntimeException that accepts only statusCode and message, avoiding the need to pass a null cause. It also updates HttpJsonClientCallImpl to use this new constructor when throwing a deadline exceeded exception. There are no review comments, and I have no feedback to provide.
whowes
force-pushed
the
whowes/get-first-header
branch
from
August 19, 2026 18:24
6f625b3 to
7c7cb65
Compare
whowes
force-pushed
the
whowes/new-exception-constructor
branch
from
August 19, 2026 18:24
7f5be2e to
57247e9
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exception class is NullMarked but needs to be constructed without a cause (once in the existing codebase with a null cause, with more expected with upcoming resumable upload support). Adding a separate constructor makes this cleaner and compatible with nullability checks.