Skip to content

feat(gax): add getFirstHeader to HttpHeadersUtils - #14115

Closed
whowes wants to merge 1 commit into
whowes/start-unary-callfrom
whowes/get-first-header
Closed

feat(gax): add getFirstHeader to HttpHeadersUtils#14115
whowes wants to merge 1 commit into
whowes/start-unary-callfrom
whowes/get-first-header

Conversation

@whowes

@whowes whowes commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Stack created with GitHub Stacks CLI • Give Feedback 💬

@whowes whowes changed the title whowes/get first header feat(gax): add getFirstHeader to HttpHeadersUtils Aug 18, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 18, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new utility method getFirstHeader in HttpHeadersUtils to retrieve the first string value of a header by case-insensitive name, supporting both single values and iterables. It also adds comprehensive unit tests in HttpHeadersUtilsTest to verify this new functionality. There are no review comments, and I have no additional feedback to provide.

@whowes
whowes force-pushed the whowes/start-unary-call branch from 9cd618b to 9ef765f Compare August 18, 2026 22:52
@whowes
whowes force-pushed the whowes/get-first-header branch from 0dbf15c to 3a364dd Compare August 18, 2026 22:52
@whowes
whowes force-pushed the whowes/start-unary-call branch from 9ef765f to 9e3e612 Compare August 18, 2026 23:39
@whowes
whowes force-pushed the whowes/get-first-header branch from 3a364dd to 4295797 Compare August 18, 2026 23:39
@whowes
whowes force-pushed the whowes/start-unary-call branch from 9e3e612 to 9ea126e Compare August 19, 2026 15:59
@whowes
whowes force-pushed the whowes/get-first-header branch 2 times, most recently from 4616b5f to 3a75d9c Compare August 19, 2026 16:22
@whowes
whowes force-pushed the whowes/start-unary-call branch from 9ea126e to 3e98a88 Compare August 19, 2026 17:15
@whowes
whowes force-pushed the whowes/get-first-header branch from 3a75d9c to 6f625b3 Compare August 19, 2026 17:15
@whowes
whowes force-pushed the whowes/start-unary-call branch from 3e98a88 to abf6f55 Compare August 19, 2026 18:24
@whowes
whowes force-pushed the whowes/get-first-header branch from 6f625b3 to 7c7cb65 Compare August 19, 2026 18:24
@sonarqubecloud

sonarqubecloud Bot commented Aug 19, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud

sonarqubecloud Bot commented Aug 19, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@whowes whowes closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@whowes