Skip to content

refactor(gax): add startUnaryCall to HttpJsonClientCalls - #14114

Draft
whowes wants to merge 1 commit into
whowes/string-http-response-parserfrom
whowes/start-unary-call
Draft

refactor(gax): add startUnaryCall to HttpJsonClientCalls#14114
whowes wants to merge 1 commit into
whowes/string-http-response-parserfrom
whowes/start-unary-call

Conversation

@whowes

@whowes whowes commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Stack created with GitHub Stacks CLI • Give Feedback 💬

@whowes whowes changed the title whowes/start unary call refactor(gax): add startUnaryCall to HttpJsonClientCalls Aug 18, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 18, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors HttpJsonClientCalls.java by extracting the core logic of starting a unary call from futureUnaryCall into a new package-private helper method startUnaryCall. This new method accepts a custom HttpJsonClientCall.Listener, allowing for more flexible call handling, while futureUnaryCall is updated to delegate to this helper using a FutureListener. There are no review comments, and I have no feedback to provide on these changes.

@whowes
whowes force-pushed the whowes/string-http-response-parser branch from 35f7e29 to d8d0e87 Compare August 18, 2026 22:52
@whowes
whowes force-pushed the whowes/start-unary-call branch 2 times, most recently from 9ef765f to 9e3e612 Compare August 18, 2026 23:39
@whowes
whowes force-pushed the whowes/string-http-response-parser branch from d8d0e87 to 12eb9d6 Compare August 18, 2026 23:39
@whowes
whowes force-pushed the whowes/start-unary-call branch from 9e3e612 to 9ea126e Compare August 19, 2026 15:59
@whowes
whowes force-pushed the whowes/string-http-response-parser branch 2 times, most recently from 6aeaca3 to c5e6e3b Compare August 19, 2026 17:15
@whowes
whowes force-pushed the whowes/start-unary-call branch from 9ea126e to 3e98a88 Compare August 19, 2026 17:15
@whowes
whowes force-pushed the whowes/start-unary-call branch from 3e98a88 to abf6f55 Compare August 19, 2026 18:24
@whowes
whowes force-pushed the whowes/string-http-response-parser branch from c5e6e3b to a5e2a65 Compare August 19, 2026 18:24
@sonarqubecloud

sonarqubecloud Bot commented Aug 19, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@sonarqubecloud

sonarqubecloud Bot commented Aug 19, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@whowes