feat(gax): allow non-JSON HttpContent in HttpRequestFormatter and HttpRequestRunnable - #14085
Draft
whowes wants to merge 1 commit into
Draft
feat(gax): allow non-JSON HttpContent in HttpRequestFormatter and HttpRequestRunnable#14085whowes wants to merge 1 commit into
whowes wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a default getHttpContent method to the HttpRequestFormatter interface, allowing formatters to customize the request body content type and payload. It refactors HttpRequestRunnable to delegate content generation to the formatter instead of hardcoding JSON serialization, and adds a unit test to verify support for non-JSON content types like binary payloads. I have no feedback to provide.
whowes
force-pushed
the
whowes/http-content-support
branch
2 times, most recently
from
August 17, 2026 22:22
81ad5bc to
1215616
Compare
whowes
force-pushed
the
whowes/http-content-support
branch
from
August 17, 2026 23:04
1215616 to
52795b5
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAX HTTP infrastructure currently assumes that request content is always JSON. This PR relaxes that assumption to allow non-JSON content, which will be needed for resumable upload support.