Skip to content

chore(java-cloud-bom): support libraries-bom/v tag format in release note workflow#13611

Merged
jinseopkim0 merged 2 commits into
googleapis:mainfrom
jinseopkim0:fix/bom-release-notes-tag-format
Jul 1, 2026
Merged

chore(java-cloud-bom): support libraries-bom/v tag format in release note workflow#13611
jinseopkim0 merged 2 commits into
googleapis:mainfrom
jinseopkim0:fix/bom-release-notes-tag-format

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

This PR updates the GHA release notes workflow .github/workflows/java-cloud-bom-release-note-generation.yaml to correctly parse and locate the GitHub Release pages corresponding to tags prefixed with libraries-bom/ (e.g. libraries-bom/v26.5.0), adapting it to the new monorepo release tag layout.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@jinseopkim0 jinseopkim0 marked this pull request as ready for review June 30, 2026 22:37
@jinseopkim0 jinseopkim0 requested review from a team as code owners June 30, 2026 22:37
@jinseopkim0 jinseopkim0 requested review from blakeli0 and lqiu96 June 30, 2026 22:37
@jinseopkim0 jinseopkim0 enabled auto-merge (squash) June 30, 2026 22:51
# Example value of GITHUB_REF: refs/tags/v26.5.0
# With the single-component setup of Release Please, the Libraries BOM
# version is the version of this repository release.
elif [[ "${GITHUB_REF}" == *"refs/tags/"* ]]; then

@lqiu96 lqiu96 Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq, does this glob need to be a bit more restrictive to only trigger on libraries-bom tags? Would this match all the tags?

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. I've updated the PR to match only the libraries-bom tags.

@jinseopkim0 jinseopkim0 force-pushed the fix/bom-release-notes-tag-format branch from a459377 to c050115 Compare July 1, 2026 00:07
@jinseopkim0 jinseopkim0 merged commit a542503 into googleapis:main Jul 1, 2026
209 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants