Skip to content

fix(ci): skip existing-versions-check for gapic-generator-java-root#13590

Merged
jinseopkim0 merged 2 commits into
googleapis:mainfrom
jinseopkim0:fix/existing-versions-check-gapic-generator-root
Jun 30, 2026
Merged

fix(ci): skip existing-versions-check for gapic-generator-java-root#13590
jinseopkim0 merged 2 commits into
googleapis:mainfrom
jinseopkim0:fix/existing-versions-check-gapic-generator-root

Conversation

@jinseopkim0

@jinseopkim0 jinseopkim0 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Fixes #12840 by correctly skipping the sdk-platform-java root POM from the duplicate release versions check.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the generation/check_existing_release_versions.sh script to exclude *sdk-platform-java/pom.xml instead of *gapic-generator-java-root* when scanning for existing version POM files. There are no review comments, so I have no feedback to provide.

@jinseopkim0 jinseopkim0 marked this pull request as ready for review June 30, 2026 14:26
@jinseopkim0 jinseopkim0 requested review from a team as code owners June 30, 2026 14:26
@jinseopkim0 jinseopkim0 requested a review from lqiu96 June 30, 2026 14:26
@jinseopkim0 jinseopkim0 enabled auto-merge (squash) June 30, 2026 14:55
@jinseopkim0 jinseopkim0 merged commit a1f3b8a into googleapis:main Jun 30, 2026
191 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

existing-versions-check failed in release PR

2 participants