fix(bigquery-jdbc): update format validation tests to create tables for the test#13588
Open
logachev wants to merge 2 commits into
Open
fix(bigquery-jdbc): update format validation tests to create tables for the test#13588logachev wants to merge 2 commits into
logachev wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new test table all_bq_types containing various BigQuery data types and populates it with sample data in ITBase.java. It also updates the integration tests in ITBigQueryJDBCTest.java to dynamically reference this table using the configured project ID and dataset. The reviewer identified an issue where using CREATE TABLE IF NOT EXISTS alongside an unconditional INSERT INTO is not idempotent, as subsequent test runs will append duplicate rows. They suggested using CREATE OR REPLACE TABLE to ensure a clean setup on each run.
Neenu1995
approved these changes
Jun 30, 2026
keshavdandeva
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test was broken twice by accidental changes to existing table; This will prevent further breaks