chore: Move introductory text for Javadoc examples into the <pre> block.#12217
Merged
jinseopkim0 merged 2 commits intomainfrom Mar 27, 2026
Merged
chore: Move introductory text for Javadoc examples into the <pre> block.#12217jinseopkim0 merged 2 commits intomainfrom
jinseopkim0 merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves descriptive Javadoc text from standard paragraphs into code blocks as comments. The reviewer recommends reverting these changes to maintain idiomatic Javadoc formatting and semantic correctness, providing specific suggestions to keep the text as preceding paragraphs for better readability in generated documentation.
Comment on lines
38
to
+39
| * <pre> | ||
| * // In order to use the emulator for a JUnit 4 test you might do something like this: |
Contributor
There was a problem hiding this comment.
While moving the introductory text into the
block makes it more convenient for copy-pasting, it is generally better for Javadoc readability to have descriptive text as a paragraph before the code example. This approach makes the generated documentation cleaner and more semantically correct. The previous implementation was more idiomatic for Javadoc.Suggested change
* <pre> * // In order to use the emulator for a JUnit 4 test you might do something like this: * <p>In order to use the emulator for a JUnit 4 test you might do something like this:</p> * * <pre>
Comment on lines
29
to
+30
| * <pre> | ||
| * // Example for connecting to a datastore: |
Contributor
There was a problem hiding this comment.
For better Javadoc readability and semantic correctness, introductory text for code examples should be in a paragraph preceding the
block. Placing it as a comment inside the block, as done here, can make the generated documentation less clean. The original approach is generally preferred.Suggested change
* <pre> * // Example for connecting to a datastore: * <p>Example for connecting to a datastore:</p> * * <pre>
lqiu96
approved these changes
Mar 26, 2026
blakeli0
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/413078744