Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the gRPC OpenTelemetry span creation to conform to OpenTelemetry RPC semantic conventions by using the fully-qualified logical name for rpc.method, deprecating rpc.service, and transitioning from rpc.system to rpc.system.name. The accompanying unit tests have been updated accordingly. Feedback on the changes suggests replacing the use of auto with an explicit std::string type for the fully_qualified_method variable to comply with the repository's style guide regarding type deduction.
| // be the fully-qualified logical name (e.g. "<service>/<method>") and that | ||
| // `rpc.service` is deprecated in favor of it. | ||
| // https://opentelemetry.io/docs/specs/semconv/rpc/rpc-spans/ | ||
| auto fully_qualified_method = |
There was a problem hiding this comment.
According to the repository style guide, auto should not be used when it obscures function return types. Since absl::StrCat returns a std::string, please declare the variable with an explicit std::string type.
std::string fully_qualified_method =References
- Reject auto when it hides function return types. (link)
This branch was successfully deployed
1 participant
No description provided.