Conversation
There was a problem hiding this comment.
Code Review
This pull request updates Bazel build files and generator templates to explicitly load C++ rules (cc_library, cc_test, and cc_binary) from @rules_cc//cc:defs.bzl. Specifically, it updates ci/showcase/BUILD.bazel.in, the quickstart build template in generator/internal/scaffold_generator.cc, and the corresponding unit test in generator/internal/scaffold_generator_test.cc. I have no feedback to provide as the changes are correct and follow best practices.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16532 +/- ##
==========================================
- Coverage 92.35% 92.34% -0.01%
==========================================
Files 2262 2262
Lines 217027 217029 +2
==========================================
- Hits 200425 200420 -5
- Misses 16602 16609 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Bazel 9 disables external rule autoloading (
--incompatible_autoload_externally=), requiring explicit@rules_cc//cc:defs.bzlload()statements in generatedBUILD.bazelfiles (ci/showcase/BUILD.bazel.inandGenerateQuickstartBuildingenerator/internal/scaffold_generator.cc).Part of b/563083065