Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the fedora-cmake-quickstart.Dockerfile to use gRPC version v1.84.0, configures additional third-party dependencies (grpc-proto and boringssl-with-bazel), and changes the SSL provider option to module. However, the specified gRPC version v1.84.0 does not exist on GitHub, which will cause the curl download to fail with a 404 error and break the Docker build. You should revert to a valid released version of gRPC.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16525 +/- ##
==========================================
- Coverage 92.36% 92.35% -0.02%
==========================================
Files 2262 2262
Lines 217027 217027
==========================================
- Hits 200460 200433 -27
- Misses 16567 16594 +27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scotthart
force-pushed
the
ci_quickstart_production_grpc_openssl_memory
branch
from
October 1, 2026 17:30
51503fe to
e9eadaf
Compare
colinmoy
approved these changes
Oct 1, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched gRPC to use its own boringssl instead of the system OpenSSL to workaround grpc/grpc#22608.
The gRPC + OpenSSL Interaction
When gRPC is built with -DgRPC_SSL_PROVIDER=package (linking system OpenSSL instead of bundled BoringSSL):