feat(storage): Add full object checksum validation for appendable uploads#16219
feat(storage): Add full object checksum validation for appendable uploads#16219v-pratap wants to merge 8 commits into
Conversation
3aad347 to
915cef5
Compare
There was a problem hiding this comment.
Code Review
This pull request adds support for CRC32C checksum validation during asynchronous uploads, specifically during finalization, resume, and flush operations. It updates the AsyncWriter interface and its underlying connection implementations to accept and verify expected checksums, and enhances HashFunction to support state retrieval and restoration. The review feedback highlights three critical issues: a compilation error in AsyncWriterConnectionImpl::Finalize caused by inconsistent return types in a lambda, and two data races in AsyncWriterConnectionResumed where impl_ is accessed concurrently without holding the appropriate mutex lock.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16219 +/- ##
==========================================
- Coverage 92.23% 92.21% -0.03%
==========================================
Files 2265 2265
Lines 210205 210340 +135
==========================================
+ Hits 193888 193967 +79
- Misses 16317 16373 +56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… in appendable uploads
…overloads without default arguments
…ck slice calculations
No description provided.