feat(ces): generate library#16010
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the new Gemini Enterprise for Customer Experience API (CES) client library into the existing codebase. It sets up the necessary build configurations, documentation, and client-side implementations for interacting with the CES services, ensuring the library is fully functional and discoverable within the project. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the C++ client library for the Gemini Enterprise for Customer Experience API (CES). The changes primarily consist of auto-generated boilerplate code, build configurations, and documentation. The overall structure is consistent with other libraries in this repository. I have identified two minor issues: the copyright year is incorrectly set to a future date across all new files, and a CMake file contains a placeholder that needs to be resolved for local testing.
| service { | ||
| service_proto_path: "google/cloud/ces/v1/agent_service.proto" | ||
| product_path: "google/cloud/ces/v1" | ||
| initial_copyright_year: "2026" |
There was a problem hiding this comment.
The initial_copyright_year is set to "2026", which is a future year. This should be updated to the current year. This issue is present for all new ces service definitions in this file and results in incorrect copyright headers in all newly generated files.
| initial_copyright_year: "2026" | |
| initial_copyright_year: "2024" |
google/cloud/ces/CMakeLists.txt
Outdated
| COMMAND | ||
| cmake -P "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake" | ||
| $<TARGET_FILE:ces_quickstart> GOOGLE_CLOUD_PROJECT | ||
| GOOGLE_CLOUD_CPP_TEST_REGION # EDIT HERE |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16010 +/- ##
=======================================
Coverage 92.63% 92.64%
=======================================
Files 2333 2333
Lines 214631 214631
=======================================
+ Hits 198827 198846 +19
+ Misses 15804 15785 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.