Revert "impl(storage): remove deprecated Client constructors"

[ivanbolwan666-dotcom]

Reverts #15869

[gemini-code-assist]

Summary of Changes

Hello @ivanbolwan666-dotcom, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a revert of a previous change, effectively restoring deprecated Client constructors and the raw_client() method within the google-cloud-cpp storage client library. This action brings back functionality that was previously marked for removal, ensuring compatibility for existing users who might still rely on these interfaces. The associated documentation and test cases have been adjusted accordingly.

Highlights

• Restore Deprecated Client Constructor: The Client(Connection, NoDecorations) constructor, which was previously removed, has been reintroduced into the Client class, marked as deprecated.
• Restore Deprecated Client::raw_client() Method: The Client::raw_client() method, also previously removed, has been restored to the Client class, marked as deprecated.
• Update Migration Guide: The doc/v3-migration-guide.md file has been updated to remove the documentation sections that detailed the removal of the Client(Connection, NoDecorations) constructor and Client::raw_client() method, reflecting their restoration.
• Revert Test Code: A test case in google/cloud/storage/grpc_plugin_test.cc has been reverted to utilize the client.raw_client() method, aligning with the restoration of this functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts the removal of deprecated storage::Client constructors and the raw_client() method. The changes correctly reintroduce these functions with deprecation attributes and update the migration guide by removing the sections related to their removal. The tests are also updated to use the restored raw_client() method. My review includes a minor suggestion in one of the test files to use an unsigned literal to prevent potential compiler warnings, improving code quality.

[gemini-code-assist]

To avoid potential compiler warnings about signed/unsigned integer comparisons, it's better to use an unsigned literal for the expected buffer size. The UploadBufferSizeOption has a type of std::size_t, which is unsigned. The literal 32 * 1024 * 1024L has type long (signed). The code being replaced in this revert correctly used UL for an unsigned long.

      32 * 1024 * 1024UL);