impl(storage): clean up remaining client_options code

[mpeddada1]

Follow up to #15848. This PR ports the rest of the usages of functions defined in client_options and removes the client options header files.

[gemini-code-assist]

Summary of Changes

Hello @mpeddada1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the client options handling within the Google Cloud Storage C++ client library. The primary goal is to centralize the logic for setting default client options, applying retry and backoff policies, and processing environment variables directly within the core Client implementation. This change simplifies the project structure by eliminating dedicated client_options files and integrating their functionality and tests into existing client components, leading to a more cohesive and maintainable codebase.

Highlights

• Code Consolidation: The client_options.cc and client_options.h files have been removed, and their functionality, including default option initialization, policy application, and environment variable parsing, has been consolidated into google/cloud/storage/client.cc and google/cloud/storage/client.h.
• Test Integration: The unit tests previously located in client_options_test.cc have been migrated and integrated into client_test.cc, ensuring comprehensive testing within the main client test suite.
• Build System Updates: The Bazel (.bzl) and CMake (.cmake) build configurations have been updated to reflect the removal of the client_options files and the integration of their associated tests.
• Dependency Cleanup: Several files across the grpc and rest internal implementations, as well as oauth2, have had their includes for client_options.h removed, streamlining dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a nice cleanup that removes the client_options.h and client_options.cc files, moving their logic into client.cc. This improves code organization as the default options logic is now co-located with the Client class initialization that uses it. The corresponding tests and build files have been updated accordingly.

I have a few minor suggestions to improve maintainability by fixing some copy-paste errors in #endif comments and to address a small amount of code duplication that was introduced.

[codecov]

Codecov Report

❌ Patch coverage is 98.71383% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.88%. Comparing base (3702697) to head (b7b87ac).
⚠️ Report is 1 commits behind head on prepare-for-v3.0.0.

Files with missing lines	Patch %	Lines
google/cloud/storage/client.cc	96.55%	4 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15868      +/-   ##
======================================================
- Coverage               92.89%   92.88%   -0.02%     
======================================================
  Files                    2398     2395       -3     
  Lines                  218531   218536       +5     
======================================================
- Hits                   203015   202991      -24     
- Misses                  15516    15545      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.