chore(spannerlib): small optimizations for fetching multiple rows in .NET#860
Open
olavloite wants to merge 1 commit into
Open
chore(spannerlib): small optimizations for fetching multiple rows in .NET#860olavloite wants to merge 1 commit into
olavloite wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates StreamingRows.cs in the .NET wrapper of spannerlib. It optimizes row buffering in TryNextCached by directly returning the first row and only enqueuing the subsequent rows, avoiding an unnecessary enqueue/dequeue cycle. Additionally, it updates NextResultSetAsync to use the asynchronous ContinueStreamingAsync method instead of the synchronous ContinueStreaming method, passing the cancellation token. There are no review comments, so no feedback is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimizations for fetching multiple rows in the SpannerLib .NET wrapper. Also changes the NextResultSetAsync method to call the ContinueStreamingAsync method.