refactor(notebooks): split notebooks by scenario#8
Open
jradcliff wants to merge 1 commit into
Open
Conversation
Change-Id: Ie325f9eec5d4873d01b1e3426d655cfaa6328830
| "source": [ | ||
| "# Advertiser Flow" | ||
| ] | ||
| }, |
Contributor
There was a problem hiding this comment.
Should we add direct links to Colab and GitHub? E.g.,
<table class="tfo-notebook-buttons nocontent" align="left">
<td>
<a target="_blank" href="https://colab.research.google.com/github/googleads/data-manager-python/blob/main/notebooks/audience_e2e_advertiser_flow.ipynb">
<img src="https://www.tensorflow.org/images/colab_logo_32px.png" />
Run in Google Colab</a>
</td>
<td>
<a target="_blank" href="https://github.com/googleads/data-manager-python/blob/main/notebooks/audience_e2e_advertiser_flow.ipynb">
<img src="https://www.tensorflow.org/images/GitHub-Mark-32px.png" />
View source on GitHub</a>
</td>
</table>
Contributor
There was a problem hiding this comment.
In the Copybara config, I had set the git_files expression to notebooks/data_partners_*.ipynb for notebooks that we want to copy to the data partner section of the devsite. Do we want to rename these notebooks to follow that pattern? Or adjust the config?
| "id": "gYjD5Fzgfbzu" | ||
| }, | ||
| "source": [ | ||
| "### Step 7. [Optional] Remove Product Link" |
Contributor
There was a problem hiding this comment.
Should we rename this to "Partner Link"?
| "id": "--2LPM7_fKZM" | ||
| }, | ||
| "source": [ | ||
| "### Step 2. Create Partner Link" |
Contributor
There was a problem hiding this comment.
Do you think it would be worth mentioning again here that they will receive an error if the service account doesn't have the right permissions in the Ads account? In case they didn't read the first line about needing admin access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Ie325f9eec5d4873d01b1e3426d655cfaa6328830