[pointer] Ptr::iter takes self by value#3421
Open
joshlf wants to merge 1 commit into
Open
Conversation
joshlf
force-pushed
the
Ibb7d512d9e12ecfd118bb018bcae10d17279c2ed
branch
from
5cf75dd to
a108b90
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3421 +/- ##
==========================================
+ Coverage 91.84% 91.85% +0.01%
==========================================
Files 20 20
Lines 6080 6093 +13
==========================================
+ Hits 5584 5597 +13
Misses 496 496 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This fixes a prior soundness hole - `Ptr::iter` took `&self`, permitting multiple overlapping `Exclusive` `Ptr`s to be created at the same time. In CI, when running `cargo-semver-checks`, don't pass `--cfg zerocopy_unstable_ptr`, as we don't want to semver-check unstable APIs. Release 0.8.50. Fixes #3419 gherrit-pr-id: Ibb7d512d9e12ecfd118bb018bcae10d17279c2ed
joshlf
force-pushed
the
Ibb7d512d9e12ecfd118bb018bcae10d17279c2ed
branch
from
a108b90 to
eaec844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a prior soundness hole -
Ptr::itertook&self, permittingmultiple overlapping
ExclusivePtrs to be created at the same time.In CI, when running
cargo-semver-checks, don't pass--cfg zerocopy_unstable_ptr, as we don't want to semver-check unstable APIs.Release 0.8.50.
Fixes #3419
Ptr::itertakesselfby value #3421Latest Update: v3 — Compare vs v2
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Ibb7d512d9e12ecfd118bb018bcae10d17279c2ed && git checkout -b pr-Ibb7d512d9e12ecfd118bb018bcae10d17279c2ed FETCH_HEADCheckout
git fetch origin refs/heads/Ibb7d512d9e12ecfd118bb018bcae10d17279c2ed && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Ibb7d512d9e12ecfd118bb018bcae10d17279c2ed && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.