Use try-with-resources for ExecutorService in ExpectTest#1640
Open
Aaron-PintoTamayo wants to merge 1 commit intogoogle:masterfrom
Open
Use try-with-resources for ExecutorService in ExpectTest#1640Aaron-PintoTamayo wants to merge 1 commit intogoogle:masterfrom
Aaron-PintoTamayo wants to merge 1 commit intogoogle:masterfrom
Conversation
cpovirk
approved these changes
Mar 26, 2026
Member
|
Ah, sorry, the CI shows trouble with Java version compatibility.... Maybe we even tried this before? Sigh. |
Author
|
I could use a finally block which guarantees shutdown on exception and works with the JDK, but I honestly think that may not be worth the added verbosity for test code and doesn't benefit it given the situation. I will dive deep into the repo and learn more about other areas. I am a bit new to this I can close the PR based on feedback. |
chaoren
added
P3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #1624
Following a suggestion from @cpovirk, refactor the executors in ExpectTest to use try-with-resources instead of manual shutdown() calls. This improves code cleanliness and ensures executors are always closed even if an exception occurs, without affecting test isolation or readability.