Guard TimeSeriesTracker against non-positive clocks and align integer types. - #607
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Guard TimeSeriesTracker against non-positive clocks and align integer types.#607copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
… types. When clock_.now() is non-positive, multiplication with absl::uint128 wraps negative values to large unsigned integers (~2^128). Clamp GetCurrentEpoch() to 0 for non-positive clock values, return size_t consistently to align with tracker epoch fields, and guard against non-positive traversal intervals. PiperOrigin-RevId: 973931607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard TimeSeriesTracker against non-positive clocks and align integer types.
When clock_.now() is non-positive, multiplication with absl::uint128 wraps
negative values to large unsigned integers (~2^128). Clamp GetCurrentEpoch()
to 0 for non-positive clock values, return size_t consistently to align with
tracker epoch fields, and guard against non-positive traversal intervals.