Skip to content

Deflake realloc GWP-ASan tests. #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 20, 2026
+19 −7
Merged

Deflake realloc GWP-ASan tests. #403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions tcmalloc/testing/memory_errors_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,14 +454,18 @@ TEST_F(TcMallocTest, ReallocLarger) {
// Note: sizes are chosen so that size + 2 access below
// does not write out of actual allocation bounds.
for (size_t size : {2, 29, 60, 505}) {
tc_globals.guardedpage_allocator().Reset();
EXPECT_DEATH(
{
fprintf(stderr, "size=%zu\n", size);
ScopedAlwaysSample always_sample;
for (size_t i = 0; i < 10000; ++i) {
char* volatile ptr = static_cast<char*>(malloc(size));
ptr = static_cast<char*>(realloc(ptr, size + 1));
ptr[size + 2] = 'A';
if (tc_globals.guardedpage_allocator().PointerIsMine(ptr) ||
kSanitizerPresent) {
ptr = static_cast<char*>(realloc(ptr, size + 1));
ptr[size + 2] = 'A';
}
free(ptr);
}
},
Expand All @@ -479,13 +483,16 @@ TEST_F(TcMallocTest, ReallocSmaller) {
#endif
for (size_t size : {8, 29, 60, 505}) {
SCOPED_TRACE(absl::StrCat("size=", size));
tc_globals.guardedpage_allocator().Reset();
EXPECT_DEATH(
{
ScopedAlwaysSample always_sample;
for (size_t i = 0; i < 10000; ++i) {
char* volatile ptr = static_cast<char*>(malloc(size));
ptr = static_cast<char*>(realloc(ptr, size - 1));
ptr[size - 1] = 'A';
if (tc_globals.guardedpage_allocator().PointerIsMine(ptr)) {
ptr = static_cast<char*>(realloc(ptr, size - 1));
ptr[size - 1] = 'A';
}
free(ptr);
}
},
Expand All @@ -500,14 +507,19 @@ TEST_F(TcMallocTest, ReallocUseAfterFree) {
#endif
for (size_t size : {8, 29, 60, 505}) {
SCOPED_TRACE(absl::StrCat("size=", size));
tc_globals.guardedpage_allocator().Reset();
EXPECT_DEATH(
{
ScopedAlwaysSample always_sample;
for (size_t i = 0; i < 10000; ++i) {
char* volatile old_ptr = static_cast<char*>(malloc(size));
void* volatile new_ptr = realloc(old_ptr, size - 1);
old_ptr[0] = 'A';
free(new_ptr);
if (tc_globals.guardedpage_allocator().PointerIsMine(old_ptr)) {
void* volatile new_ptr = realloc(old_ptr, size - 1);
old_ptr[0] = 'A';
free(new_ptr);
} else {
free(old_ptr);
}
}
},
"has detected a memory error");
Expand Down
Loading