fix: force_log_type flag for ingest log method#174
Merged
mihirvala08 merged 2 commits intomainfrom Feb 3, 2026
Merged
Conversation
Collaborator
Author
|
/run-integration-tests bc84f8a |
Collaborator
Author
|
/run-integration-tests 604f293 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed
ingest_log()method to correctly skip log type validation whenforce_log_type=True, preventing unnecessary API calls.resolves #173
Problem
The
force_log_typeparameter was intended to bypass log type validation (which requires additional IAM access), but the implementation was checking the API before evaluating the flag due to incorrect condition order.Changes
src/secops/chronicle/log_ingest.py: Fixed condition order iningest_log()method (line 825)tests/chronicle/test_log_ingest.py: Added unit tests to verify: