feat(a11y): announce dynamic location in Santa tracker button #239
+70
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenTandrian
changed the title
Collaborator
Author
|
Santa is stopping at a location: 
Santa is heading to a location: 
|
Jezzamonn
reviewed
Dec 23, 2025
Comment on lines
69
to
77
| let label = _msg`santasearch_character_santa`; | ||
| if (this.locationLabel) { | ||
| if (this.stop) { | ||
| label = label + ` is at ${this.locationLabel}`; | ||
| } else { | ||
| label = label + ` is heading to ${this.locationLabel}`; | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Hm. I think this might end up being awkward for languages other than English. Might need to figure out how to dynamically generate this string in a way that works for multiple languages
Collaborator
Author
There was a problem hiding this comment.
That makes sense. I think a better way would be to add translation entries.
Collaborator
Author
There was a problem hiding this comment.
I have changed it to use translation entries and replace {{location}} variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an accessibility issue where the "Santa image" button only announced "Santa Claus" without providing context about his current location or status. Screen reader users would land on the button but receive no useful information about where Santa currently is in the world.
Changes
SantaSantaElementto accept a locationLabel property and dynamically update the button text.ModvilTrackerElementto extract the city and region from the data manager and pass it correctly to thesanta-santacomponent.tracker_santa_is_atandtracker_santa_is_heading_towith{{location}}placeholders to ensure proper grammar and translation across languages.en,en-GB,zh-CN,zh-TW,zh-HK,ja, andko.Impacted UI components
modvil-tracker)santa-santa)