Fix reached_preemption crash when JAX preemption service is disabled#3458
Open
marsunique wants to merge 1 commit into
Open
Fix reached_preemption crash when JAX preemption service is disabled#3458marsunique wants to merge 1 commit into
marsunique wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3406
When JAX's preemption service is disabled via
jax_enable_preemption_service=False,multihost_utils.reached_preemption_sync_pointraises aRuntimeErrorbecause thepreemption sync manager is
None. This causesCheckpointManager.save()to crash.This change catches the
RuntimeErrorinreached_preemption()and returnsFalse,gracefully treating a disabled preemption service as "no preemption detected".
Type of change
Checklist
CHANGELOG.mdunder the[Unreleased]section (or the relevantcheckpoint//export/changelog).