Rename action to github_action

Author: Dillon Nys

mono_repo/lib/src/commands/github/github_yaml.dart

@@ -273,39 +273,41 @@ extension on CIJobEntry {
     for (var package in packages) {
       final pubStepId = '${package.replaceAll('/', '_')}_'
           'pub_${rootConfig.monoConfig.pubAction}';
-      commandEntries.add(GitHubActionConfig(
-        name: '$package; $pubCommand',
-        run: pubCommand,
-        id: pubStepId,
-        // Run this regardless of the success of other steps other than the
-        // pub step.
-        ifCondition: "always() && steps.checkout.conclusion == 'success'",
-        workingDirectory: package,
-      ));
+      commandEntries.add(
+        GitHubActionConfig(
+          name: '$package; $pubCommand',
+          run: pubCommand,
+          id: pubStepId,
+          // Run this regardless of the success of other steps other than the
+          // pub step.
+          ifCondition: "always() && steps.checkout.conclusion == 'success'",
+          workingDirectory: package,
+        ),
+      );
       for (var i = 0; i < commands.length; i++) {
         final task = job.tasks[i];
-        var action = task.action;
+        var githubAction = task.githubAction;
 
         // If the task specifies a full action, update the job-specific
         // properties with the current context.
-        if (action != null) {
-          var workingDirectory = action.workingDirectory;
+        if (githubAction != null) {
+          var workingDirectory = githubAction.workingDirectory;
           if (workingDirectory != null) {
             workingDirectory = posix.normalize(
               posix.join(package, workingDirectory),
             );
           }
-          var ifCondition = action.ifCondition;
+          var ifCondition = githubAction.ifCondition;
           if (ifCondition != null) {
             ifCondition += " && steps.$pubStepId.conclusion == 'success'";
           }
-          action = action.copyWith(
+          githubAction = githubAction.copyWith(
             workingDirectory: workingDirectory,
             ifCondition: ifCondition,
           );
         }
         commandEntries.add(
-          action ??
+          githubAction ??
               GitHubActionConfig(
                 name: '$package; ${task.command}',
                 run: _commandForOs(task.command),

mono_repo/lib/src/package_config.dart

@@ -344,7 +344,13 @@ class Task {
     'dartfmt': 'format',
     'dartanalyzer': 'analyze',
   };
-  static const _tasks = {'format', 'analyze', 'test', 'command', 'action'};
+  static const _tasks = {
+    'format',
+    'analyze',
+    'test',
+    'command',
+    'github_action'
+  };
   static final _allowedTaskNames = UnmodifiableSetView({
     ..._oldToNewTaskNames.keys,
     ..._tasks,
@@ -360,11 +366,11 @@ class Task {
 
   final String command;
 
-  final GitHubActionConfig? action;
+  final GitHubActionConfig? githubAction;
 
-  Task(this.flavor, this.name, {this.args, this.action})
-      : command = action != null
-            ? action.command
+  Task(this.flavor, this.name, {this.args, this.githubAction})
+      : command = githubAction != null
+            ? githubAction.command
             : _commandValue(flavor, name, args).join(' ');
 
   /// Parses an individual item under `stages`, which might be a `group` or an
@@ -427,18 +433,18 @@ class Task {
       }
       final taskName = _normalizeTaskName(taskNames.single);
 
-      if (taskName == 'action') {
-        final actionYaml = yamlValue['action'] as Object?;
-        if (actionYaml is! Map) {
+      if (taskName == 'github_action') {
+        final githubActionYaml = yamlValue['github_action'] as Object?;
+        if (githubActionYaml is! Map) {
           throw CheckedFromJsonException(
             yamlValue,
-            'action',
-            'Task',
+            'github_action',
+            'GitHubActionConfig',
             'Must be a map',
           );
         }
-        final action = GitHubActionConfig.fromJson(actionYaml);
-        return Task(flavor, 'action', action: action);
+        final githubAction = GitHubActionConfig.fromJson(githubActionYaml);
+        return Task(flavor, 'github_action', githubAction: githubAction);
       }
 
       String? args;

mono_repo/lib/src/package_config.g.dart

@@ -1178,7 +1178,7 @@ sdk:
 
 stages:
   - custom_step:
-      - action:
+      - github_action:
           id: custom-scripts
           run: | 
             ./script_a
@@ -1242,7 +1242,7 @@ sdk:
 
 stages:
   - custom_step:
-      - action:
+      - github_action:
           id: custom-script
           if: always()
           run: ./script
@@ -1276,7 +1276,7 @@ sdk:
 
 stages:
   - custom_step:
-      - action:
+      - github_action:
           run: ./script
           some-key: some-value
 ''')

mono_repo/test/generate_test.dart

@@ -210,7 +210,7 @@ line 4, column 12: Unsupported value for "group". expected a list of tasks
       _expectParseThrows(
         monoYaml,
         r'''
-line 9, column 6: Must have one key of `format`, `analyze`, `test`, `command`, `action`.
+line 9, column 6: Must have one key of `format`, `analyze`, `test`, `command`, `github_action`.
   ╷
 9 │      "weird": "thing"
   │      ^^^^^^^
@@ -233,7 +233,7 @@ line 9, column 6: Must have one key of `format`, `analyze`, `test`, `command`, `
       _expectParseThrows(
         monoYaml,
         r'''
-line 10, column 6: Must have one and only one key of `format`, `analyze`, `test`, `command`, `action`.
+line 10, column 6: Must have one and only one key of `format`, `analyze`, `test`, `command`, `github_action`.
    ╷
 10 │      "command": "other thing"
    │      ^^^^^^^^^
@@ -415,7 +415,7 @@ stages:
     - test: --preset travis --total-shards 5 --shard-index 1
     - test #no args
     - group:
-      - action:
+      - github_action:
           run: npm run build
           uses: actions/setup-node@v3
           with:
@@ -623,8 +623,8 @@ List get _testConfig1expectedOutput => [
         'tasks': [
           {
             'flavor': 'dart',
-            'name': 'action',
-            'action': {
+            'name': 'github_action',
+            'githubAction': {
               'run': 'npm run build',
               'uses': 'actions/setup-node@v3',
               'with': {'node-version': '16'},
@@ -647,8 +647,8 @@ List get _testConfig1expectedOutput => [
         'tasks': [
           {
             'flavor': 'dart',
-            'name': 'action',
-            'action': {
+            'name': 'github_action',
+            'githubAction': {
               'run': 'npm run build',
               'uses': 'actions/setup-node@v3',
               'with': {'node-version': '16'},
@@ -671,8 +671,8 @@ List get _testConfig1expectedOutput => [
         'tasks': [
           {
             'flavor': 'dart',
-            'name': 'action',
-            'action': {
+            'name': 'github_action',
+            'githubAction': {
               'run': 'npm run build',
               'uses': 'actions/setup-node@v3',
               'with': {'node-version': '16'},