Merge remote-tracking branch 'google/master' into feat/actions-config

Author: Dillon Nys

.gitattributes

@@ -0,0 +1,2 @@
+.github/workflows/dart.yml linguist-generated=true
+tool/ci.sh linguist-generated=true

.github/workflows/dart.yml

@@ -37,6 +37,7 @@ linter:
     - constant_identifier_names
     - control_flow_in_finally
     - curly_braces_in_flow_control_structures
+    - depend_on_referenced_packages
     - directives_ordering
     - empty_catches
     - empty_constructor_bodies
@@ -49,13 +50,17 @@ linter:
     - join_return_with_assignment
     - library_names
     - library_prefixes
+    - library_private_types_in_public_api
     - lines_longer_than_80_chars
     - list_remove_unrelated_type
     - literal_only_boolean_expressions
     - missing_whitespace_between_adjacent_strings
     - no_duplicate_case_values
+    - no_leading_underscores_for_library_prefixes
+    - no_leading_underscores_for_local_identifiers
     - no_runtimeType_toString
     - non_constant_identifier_names
+    - null_check_on_nullable_type_parameter
     - null_closures
     - omit_local_variable_types
     - only_throw_errors
@@ -93,20 +98,25 @@ linter:
     - prefer_void_to_null
     - provide_deprecation_message
     - recursive_getters
+    - require_trailing_commas
     - slash_for_doc_comments
     - sort_pub_dependencies
+    - sort_unnamed_constructors_first
     - test_types_in_equals
     - throw_in_finally
     - type_annotate_public_apis
     - type_init_formals
     - unawaited_futures
     - unnecessary_brace_in_string_interps
     - unnecessary_const
+    - unnecessary_constructor_name
     - unnecessary_getters_setters
     - unnecessary_lambdas
+    - unnecessary_late
     - unnecessary_new
     - unnecessary_null_aware_assignments
     - unnecessary_null_in_if_null_operators
+    - unnecessary_nullable_for_final_variable_declarations
     - unnecessary_overrides
     - unnecessary_parenthesis
     - unnecessary_statements
@@ -117,5 +127,6 @@ linter:
     - use_is_even_rather_than_modulo
     - use_rethrow_when_possible
     - use_string_buffers
+    - use_super_parameters
     - valid_regexps
     - void_checks

analysis_options.yaml

@@ -1,6 +1,8 @@
 ## 6.3.0-dev
 
 - Update to `subosito/flutter-action@v2.4.0`.
+- Require at least Dart >= 2.17.0
+- Add the `list` command.
 
 ## 6.2.2
 

mono_repo/CHANGELOG.md

@@ -34,6 +34,7 @@ Global options:
 Available commands:
   check       Check the state of the repository.
   generate    Generates the CI configuration for child packages.
+  list        List all packages configured for mono_repo.
   presubmit   Run the CI presubmits locally.
   pub         Runs the `pub` command with the provided arguments across all packages.
 

mono_repo/README.md

@@ -13,3 +13,7 @@ targets:
         options:
           any_map: true
           checked: true
+      source_gen:combining_builder:
+        options:
+          ignore_for_file:
+          - require_trailing_commas

mono_repo/build.yaml

@@ -29,8 +29,9 @@ Map<String, String> generateGitHubYml(
 
   final allJobStages = {for (var job in jobs) job.stageName};
   final orderedStages = calculateOrderedStages(
-      rootConfig, rootConfig.monoConfig.githubConditionalStages)
-    ..add(_onCompletionStage);
+    rootConfig,
+    rootConfig.monoConfig.githubConditionalStages,
+  )..add(_onCompletionStage);
 
   final output = <String, String>{};
 
@@ -203,24 +204,26 @@ Iterable<_MapEntryWithStage> _listJobs(
     if (mergeStages.contains(first.job.stageName)) {
       final packages = entry.value.map((t) => t.job.package).toList()..sort();
       yield jobEntry(
-          first.jobYaml(
+        first.jobYaml(
+          rootConfig,
+          packages: packages,
+          oneOs: differentOperatingSystems.length == 1,
+          oneSdk: differentSdks.length == 1,
+          onePackage: differentPackages.length == 1,
+        ),
+        first.job.stageName,
+      );
+    } else {
+      yield* entry.value.map(
+        (e) => jobEntry(
+          e.jobYaml(
             rootConfig,
-            packages: packages,
             oneOs: differentOperatingSystems.length == 1,
             oneSdk: differentSdks.length == 1,
             onePackage: differentPackages.length == 1,
           ),
-          first.job.stageName);
-    } else {
-      yield* entry.value.map(
-        (e) => jobEntry(
-            e.jobYaml(
-              rootConfig,
-              oneOs: differentOperatingSystems.length == 1,
-              oneSdk: differentSdks.length == 1,
-              onePackage: differentPackages.length == 1,
-            ),
-            e.job.stageName),
+          e.job.stageName,
+        ),
       );
     }
   }
@@ -229,9 +232,12 @@ Iterable<_MapEntryWithStage> _listJobs(
   // appropriate `needs` config to each.
   if (onCompletionJobs != null && onCompletionJobs.isNotEmpty) {
     for (var jobConfig in onCompletionJobs) {
-      yield jobEntry({
-        ...jobConfig,
-      }, _onCompletionStage);
+      yield jobEntry(
+        {
+          ...jobConfig,
+        },
+        _onCompletionStage,
+      );
     }
   }
 }