Add key frame to asserts#1010
Open
skyyaoyao wants to merge 2 commits into
Open
Conversation
added 2 commits
July 14, 2026 09:45
Automatically captures key frame data (action, timestamp, details) upon any Mobly assertion failure and injects it into the extras dictionary to ensure it is captured in the test_summary.yaml file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR automatically captures key frame data (
action,timestamp, anddetails) upon any Mobly assertion failure and injects it into the test records.By injecting this into the assertion's
extrasdictionary, we ensure the metadata is seamlessly captured into thetest_summary.yamlfor downstream parsers, without requiring manual tracking or adding overhead to passing assertions.A new
_add_key_framehelper is implemented and tied into both standard unittest wrappers (_call_unittest_assertion) and direct Mobly assertions (fail()).Testing Done
key_frameblock successfully serializes intotest_summary.yamllogs upon assertion failures with real Mobly test.pytest tests/mobly). Updated the internalbase_test_test.pytests that rigorously expectedactual_record.extrasto beNoneto instead gracefully accept the injectedkey_framedata on failures.