Add some additional debug logging to regalloc_trace_worker#554
Open
boomanaiden154 wants to merge 2 commits intogoogle:mainfrom
Open
Add some additional debug logging to regalloc_trace_worker#554boomanaiden154 wants to merge 2 commits intogoogle:mainfrom
boomanaiden154 wants to merge 2 commits intogoogle:mainfrom
Conversation
Given these workers typically run on remote machines, it's hard to tell what is going on without debug logging. Add some debug entries that I found useful when getting things spun up recently. This especially makes debugging performance issues easier as at least you can see where the issue is (e.g., copying the corpus taking an hour+ because you didn't realize the data needed to move between DCs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given these workers typically run on remote machines, it's hard to tell what is going on without debug logging. Add some debug entries that I found useful when getting things spun up recently. This especially makes debugging performance issues easier as at least you can see where the issue is (e.g., copying the corpus taking an hour+ because you didn't realize the data needed to move between DCs).