Skip to content

Fix std.parseJson/parseYaml abort on number overflow #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rwinkelman wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix std.parseJson/parseYaml abort on number overflow #1338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9abd5dc
Fix std.parseJson/parseYaml abort on number overflow
rwinkelman Sep 28, 2026
bf6c023
chore: retrigger Google CLA check
rwinkelman Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/vm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1702,7 +1702,9 @@ class Interpreter {

bool filled;
otherJsonToHeap(j, filled, scratch);
} catch (const json::parse_error &e) {
} catch (const json::exception &e) {
// parse_error and out_of_range (e.g. 1E999) must become RuntimeError,
// not escape to libjsonnet's CATCH and abort. See #1337.
throw makeError(loc, e.what());
}

Expand Down Expand Up @@ -1737,6 +1739,10 @@ class Interpreter {
}
} catch (const RapidYamlError& exc) {
throw makeError(loc, exc.msg_);
} catch (const json::exception &e) {
// RapidYAML may emit JSON text that json::parse rejects with
// out_of_range (number overflow), not only parse_error. See #1337.
throw makeError(loc, e.what());
}
bool filled_unused;
otherJsonToHeap(j, filled_unused, scratch);
Expand Down
Loading