Remove permitted.reduce(excluded) optimization in X.509 NameConstraints.#2803
Open
copybara-service[bot] wants to merge 1 commit into
Open
Remove permitted.reduce(excluded) optimization in X.509 NameConstraints.#2803copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
A logic flaw in the Sun PKIX CertPathValidator X.509 NameConstraints validation allows an attacker with a constrained intermediate CA to craft unauthorized certificates for arbitrary domains and perform TLS Man-in-the-Middle (MITM) attacks. Specifically, an optional optimization using permitted.reduce(excluded) could remove the last permitted subtree of a specific type. This caused the verify() method to incorrectly short-circuit and approve the certificate, effectively dropping the name constraint. To resolve this issue, this commit removes the permitted.reduce(excluded) optimization from NameConstraintsExtension.java and Builder.java. Because this step was strictly an optimization and not required for algorithmic correctness, removing it ensures that constraints are properly retained and correctly enforced during certificate path validation. Test: built and verified locally FEATURE: N/A RELNOTES: Remove permitted.reduce(excluded) optimization in X.509 NameConstraints path validation to prevent constraint bypass. PiperOrigin-RevId: 935167126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove permitted.reduce(excluded) optimization in X.509 NameConstraints.
A logic flaw in the Sun PKIX CertPathValidator X.509 NameConstraints validation allows an attacker with a constrained intermediate CA to craft unauthorized certificates for arbitrary domains and perform TLS Man-in-the-Middle (MITM) attacks. Specifically, an optional optimization using permitted.reduce(excluded) could remove the last permitted subtree of a specific type. This caused the verify() method to incorrectly short-circuit and approve the certificate, effectively dropping the name constraint.
To resolve this issue, this commit removes the permitted.reduce(excluded) optimization from NameConstraintsExtension.java and Builder.java. Because this step was strictly an optimization and not required for algorithmic correctness, removing it ensures that constraints are properly retained and correctly enforced during certificate path validation.
Test: built and verified locally
FEATURE: N/A
RELNOTES: Remove permitted.reduce(excluded) optimization in X.509 NameConstraints path validation to prevent constraint bypass.