Skip to content

internal change #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
Open

internal change #807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions init2winit/checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ def save_unreplicated_checkpoint(
# So we first all_gather it to the host and then call jax.device_get
if jax.process_count() > 1:
unreplicated_optimizer_state = jax.device_get(
process_allgather(optimizer_state))
unreplicated_params = jax.device_get(process_allgather(params))
process_allgather(optimizer_state, tiled=True))
unreplicated_params = jax.device_get(process_allgather(params, tiled=True))
else:
unreplicated_optimizer_state = jax.device_get(optimizer_state)
unreplicated_params = jax.device_get(params)
Expand Down
4 changes: 2 additions & 2 deletions init2winit/trainer_lib/trainer_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ def evaluate(
# `merge` aggregates the metrics across batches.
metrics = metrics.merge(computed_metrics)

metrics = jax.device_get(process_allgather(metrics))
metrics = jax.tree_util.tree_map(lambda x: x[0] if x.ndim > 0 else x, metrics)
metrics = jax.device_get(process_allgather(metrics, tiled=True))
metrics = jax.tree_util.tree_map(lambda x: x[0] if x.ndim > 1 else x, metrics)
# For data splits with no data (e.g. Imagenet no test set) no values
# will appear for that split.
if metrics is not None:
Expand Down