Skip to content

Clean up unused args in base_trainer. These were introduced by the quantization trainer which was removed over a year ago. #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean up unused args in base_trainer. These were introduced by the quantization trainer which was removed over a year ago. #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions init2winit/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,6 @@ def _run(
training_metrics_config=training_metrics_config,
callback_configs=callback_configs,
external_checkpoint_path=external_checkpoint_path,
dataset_meta_data=dataset_meta_data,
loss_name=loss_name,
metrics_name=metrics_name,
data_selector=data_selector,
).train()
)
Expand Down
15 changes: 0 additions & 15 deletions init2winit/trainer_lib/base_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ def __init__(
training_metrics_config=None,
callback_configs=None,
external_checkpoint_path=None,
dataset_meta_data=None,
loss_name=None,
metrics_name=None,
data_selector=None,
training_algorithm_class=training_algorithm.OptaxTrainingAlgorithm,
):
Expand Down Expand Up @@ -125,22 +122,10 @@ def __init__(
external_checkpoint_path: (str) If this argument is set, we will load the
optimizer_state, params, batch_stats, and training_metrics from the
checkpoint at this location.
dataset_meta_data: meta_data about the dataset. It is not directly used in
the base trainer. Users are expected to overwrite the initialization
method in a customimzed trainer to access it.
loss_name: name of the loss function. Not directly used in base trainer.
Users are expected to overwrite the initialization method in a
customimzed trainer to access it.
metrics_name: Not directly used in the base trainer. Users are expected to
overwrite the initialization method in a customimzed trainer to access
it.
data_selector: data selection function returned by
datasets.get_data_selector.
training_algorithm_class: Class of training algorithm to use.
"""
del dataset_meta_data
del loss_name
del metrics_name
self._train_dir = train_dir
self._model = model
self._dataset_builder = dataset_builder
Expand Down