Fix panic in iptables UserChainTarget.Action(). - #13992
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test/cl959207671
branch
5 times, most recently
from
August 5, 2026 21:22
b6dd0e9 to
7b06d2d
Compare
Prior to this CL, we assumed that execution would never fall through to UserChainTargets, because every chain ends with an unconditional RETURN or policy rule. This is not true with setsockopt(IP6T_SO_SET_REPLACE), with which a userspace program can supply an arbitrary table layout. Linux already rejects such tables, and so now we do too. Additionally, such failures in Linux are handled by just calling ipt_error which logs an error message instead of panicking, so replacing our panic with a BugTracebackOnce makes sense as well. This traceback isn't triggered, but it's here just for future-proofing. PiperOrigin-RevId: 959886702
copybara-service
Bot
force-pushed
the
test/cl959207671
branch
from
August 5, 2026 22:02
7b06d2d to
9d9b068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix panic in iptables UserChainTarget.Action().
Prior to this CL, we assumed that execution would never fall through to
UserChainTargets, because every chain ends with an unconditional RETURN or
policy rule. This is not true with setsockopt(IP6T_SO_SET_REPLACE), with which
a userspace program can supply an arbitrary table layout.
Linux already rejects such tables, and so now we do too. Additionally, such
failures in Linux are handled by just calling ipt_error which logs an error
message instead of panicking, so replacing our panic with a BugTracebackOnce
makes sense as well. This traceback isn't triggered, but it's here just for
future-proofing.